Make 3D Triangulate possible with pytorch_dlc branch and MA project#2729
Merged
MMathisLab merged 3 commits intoDeepLabCut:pytorch_dlcfrom Sep 9, 2024
Merged
Conversation
* Compute triangulated data with pose_estimation_pytorch * Make correct MultiIndex with unique bodyparts * adapt to DataFrame.to_hdf() changes
Member
|
thanks so much for your contribution! This is super helpful! |
MMathisLab
approved these changes
Sep 5, 2024
n-poulsen
suggested changes
Sep 6, 2024
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
There was a problem hiding this comment.
Thanks @Zelin2001, this looks great! Just suggested a few changes, let me know if you want to discuss anything.
One the changes are made this looks good to me :)
Contributor
Author
Thank you a lot for the advice @n-poulsen . I've learned more about deeplabcut from these changes. |
n-poulsen
approved these changes
Sep 9, 2024
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @Zelin2001!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationality
I proceeded with my project, and then found the
triangulate()function dependent on TensorFlow modules. Further debugging revealed more problems relating to the 'single' individual, who has a different bodypart dimension from common individuals.Finally, I made minor changes to make triangulation work on my dataset. These changes might also help with other 3D MA users.
Changes
Compute triangulated data with pose_estimation_pytorch
Make correct MultiIndex with unique bodyparts
adapt to DataFrame.to_hdf() changes