Skip to content

Cyclic graph resolving#174

Merged
Entenwilli merged 96 commits intomainfrom
microsecnd-to-dags
Aug 7, 2024
Merged

Cyclic graph resolving#174
Entenwilli merged 96 commits intomainfrom
microsecnd-to-dags

Conversation

@BenjaminArp
Copy link
Contributor

@BenjaminArp BenjaminArp commented Jun 25, 2024

Development finished for Cyclic graph resolving:

Smaller ToDos:

  • give feeback when resolving cycles, print?
  • testing (currently online shop & Tuhh data )
  • resolve conflicts

Relevant files for Review:

  • bundles/org.dataflowanalysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDCyclicTransposeFlowGraphFinder.java
  • bundles/org.dataflowanalysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/DFDConfidentialityAnalysis.java
  • bundles/org.dataflowanalysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/DFDDataFlowAnalysisBuilder.java
  • bundles/org.dataflowanalysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDFlowGraphCollection.java
  • bundles/org.dataflowanalysis.analysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDTransposeFlowGraphFinder.java
  • bundles/org.dataflowanalysis.analysis/src/org/dataflowanalysis/analysis/core/FlowGraphCollection.java

uuqjz and others added 30 commits April 16, 2024 09:13
InformationFlow class removed "_".

Added function to initialize the Microsecend dfd to fit our analysis
anilallewar trhoughs errors during building and constraint testing! Fix not yet found
Startet implementing cyclic analysis behavior:
Changed loop to be more efficent
Added new Class
Current Status:
ACyclic graphs: Work as intended (no time impact)
Cyclic graphs: Don´t crash but endless loop (at least i think)
Fitted my algorithm to the changes done to the transpose flow graph finder from main

Problem to much calls of handle flow and Determin sionk --> current version does not termiante for loops. Solution idea enter added logic on higher level so less traffic is generated.
Outputs a promising transpose flow but analysis can´t handle?
To make inheritence possible i needed to change private to protected
Tested anilallewar with constraints with 3 mistakes:
6: seems correct model failure on tuh side?
11 & 12 : no idea why
TUH problem:
model 6 internal data without auth server
@BenjaminArp BenjaminArp requested review from Entenwilli and uuqjz July 18, 2024 09:02
@sebinside sebinside added this to the 3.0.0 milestone Jul 30, 2024
Copy link
Collaborator

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some small things, mostly test-related

uuqjz
uuqjz previously approved these changes Aug 4, 2024
Copy link
Collaborator

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMN

sebinside
sebinside previously approved these changes Aug 7, 2024
Copy link
Member

@Entenwilli Entenwilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some smaller code style changes.
From a cursory glance, I did not find any issues with the functionality of the Cyclic Transpose Flow Graph Finder

@BenjaminArp BenjaminArp dismissed stale reviews from sebinside and uuqjz via 92c1666 August 7, 2024 13:28
@BenjaminArp BenjaminArp requested a review from Entenwilli August 7, 2024 13:29
Copy link
Member

@Entenwilli Entenwilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Entenwilli Entenwilli merged commit e088322 into main Aug 7, 2024
@Entenwilli Entenwilli deleted the microsecnd-to-dags branch August 16, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve cyclic data flow graphs Insufficient handling of cyclic transpose flow graphs

4 participants