Merged
Conversation
InformationFlow class removed "_". Added function to initialize the Microsecend dfd to fit our analysis
anilallewar trhoughs errors during building and constraint testing! Fix not yet found
Startet implementing cyclic analysis behavior: Changed loop to be more efficent Added new Class Current Status: ACyclic graphs: Work as intended (no time impact) Cyclic graphs: Don´t crash but endless loop (at least i think)
Fitted my algorithm to the changes done to the transpose flow graph finder from main Problem to much calls of handle flow and Determin sionk --> current version does not termiante for loops. Solution idea enter added logic on higher level so less traffic is generated.
Outputs a promising transpose flow but analysis can´t handle?
To make inheritence possible i needed to change private to protected
Tested anilallewar with constraints with 3 mistakes: 6: seems correct model failure on tuh side? 11 & 12 : no idea why
…wgraph collection
TUH problem: model 6 internal data without auth server
uuqjz
reviewed
Jul 17, 2024
...flowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/MicroSecEndTest.java
Outdated
Show resolved
Hide resolved
…sis/DataFlowAnalysis into microsecnd-to-dags
uuqjz
reviewed
Aug 4, 2024
Collaborator
uuqjz
left a comment
There was a problem hiding this comment.
Found some small things, mostly test-related
...flowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/MicroSecEndTest.java
Outdated
Show resolved
Hide resolved
...flowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/MicroSecEndTest.java
Outdated
Show resolved
Hide resolved
...flowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/MicroSecEndTest.java
Show resolved
Hide resolved
...flowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/MicroSecEndTest.java
Show resolved
Hide resolved
...alysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDCyclicTransposeFlowGraphFinder.java
Outdated
Show resolved
Hide resolved
...alysis.dfd/src/org/dataflowanalysis/analysis/dfd/core/DFDCyclicTransposeFlowGraphFinder.java
Outdated
Show resolved
Hide resolved
sebinside
previously approved these changes
Aug 7, 2024
Entenwilli
requested changes
Aug 7, 2024
Member
Entenwilli
left a comment
There was a problem hiding this comment.
Only some smaller code style changes.
From a cursory glance, I did not find any issues with the functionality of the Cyclic Transpose Flow Graph Finder
...lowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/CyclicFinderTest.java
Outdated
Show resolved
Hide resolved
...lowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/CyclicFinderTest.java
Outdated
Show resolved
Hide resolved
...lowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/CyclicFinderTest.java
Outdated
Show resolved
Hide resolved
...lowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/CyclicFinderTest.java
Outdated
Show resolved
Hide resolved
...lowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/CyclicFinderTest.java
Outdated
Show resolved
Hide resolved
...lowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/CyclicFinderTest.java
Outdated
Show resolved
Hide resolved
...lowanalysis.analysis.tests/src/org/dataflowanalysis/analysis/tests/dfd/CyclicFinderTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development finished for Cyclic graph resolving:
Smaller ToDos:
Relevant files for Review: