Add common security acronyms and brand nouns to SIEM-Names namecase exceptions#94
Closed
zmackie-datadog wants to merge 1 commit into
Closed
Add common security acronyms and brand nouns to SIEM-Names namecase exceptions#94zmackie-datadog wants to merge 1 commit into
zmackie-datadog wants to merge 1 commit into
Conversation
Adds Anthropic, API, Claude, CLI, DNS, IP, MFA, RBAC, SSO, URL to the exceptions list. These appear unmodified in scores of production SIEM detection rule names today and need to be allowed by the namecase check so that new rule authoring is consistent with established convention. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Anthropic, API, Claude, CLI, DNS, IP, MFA, RBAC, SSO, URL to the
SIEM-Names/namecase.ymlexceptions list so the namecase check no longer flags rule names that follow the team's established naming convention.Why this matters
The
SIEM-Names.namecasevale rule extendscapitalizationwithmatch: $sentence, requiring rule names to be in sentence case unless a substring appears in theexceptionslist. The current list is heavily phrase-oriented (e.g.,Auth0 Guardian MFA,AWS Console login without MFA,Auth0 Suspicious IP Throttling) and lacks generic acronym entries. As a result, scores of production SIEM rules inDataDog/security-monitoringwould fail this check if re-validated today — they don't get re-checked because the pre-commit hook only runs on modified files.Survey of
cloud-siem/log-detection/production/rule names (861 total):IPAuth0 Suspicious IP Throttling)MFAAPIAPI calls)DNSURLSSOCLIRBACExamples that currently pass CI on
prodbut would be blocked from any modification until this PR lands:"Activity observed from malicious IP""Atlassian administrative API token activity observed""Slack CLI login from suspicious IP address""Azure AD MFA disabled""Gitlab SSO disabled""GitHub IP allow list"Concrete impact (motivating case)
Authoring the new Anthropic Compliance SIEM rule pack (zmackie/anthropic-compliance-scaffold) hit this wall: 9 of 21 scaffold rules tripped
SIEM-Names.namecasefor usingSSO,API,IP,RBAC, orClaude— the same acronyms that production Slack, Atlassian, GitHub, Azure, and Auth0 packs use without expansion. With these exceptions added, the 9 rule names pass validation unchanged.Brand nouns
AnthropicandClaudeare added alongside the acronyms because the new SaaS audit-log integration ("Claude Compliance") will use both in rule names. This follows the existing convention of registering single-word product brands (Cloudflare,GitHub,Okta,JumpCloud,1Password,TruffleHog,Tor).Verification
Local vale run before this change, against the 9 failing Anthropic-Compliance rule names plus 5 production examples that would also fail:
After this change, all 14 pass:
Test plan
"Anthropic Compliance Foo Bar"whereFooandBararen't proper nouns)rule-validationinDataDog/security-monitoringpasses for the Anthropic Compliance scaffold once this lands🤖 Generated with Claude Code