-
-
Notifications
You must be signed in to change notification settings - Fork 316
DSharpPlus.Voice #2404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
akiraveliara
wants to merge
61
commits into
master
Choose a base branch
from
voice-rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DSharpPlus.Voice #2404
+7,018
−4,117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: lib/libaerith/inc/dave git-subtree-split: 6e5ffbc1cb4eef6be96e8115c4626be598b7e501
still missing some methods, but
also makes the c++ nicer to interface with and also fully delete vnext, not sure why it was still there
voicenext used the sodium status code as a length lmao
…ransport added media transport service
…4-era networking plumbing
…tService. Changed TransportService to use ArrayPoolBufferWriter instead of MemoryStream.
…rt-service Initial commit for transport service.
…voice-events Initial implementation of dave negotiation handling.
next up: opus writers and actually reading and signaling the audio
we'll insert it later, at send time, when we actually know sequence and timestamp
Plerx2493
reviewed
Dec 21, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial xmldocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the initial pull request for DSharpPlus.Voice. opening early to get feedback on some of the code structure
todo: