Nullable annotations for DSP core package, and minor refactoring #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`Contains(T item)`
…h LINQ, and added nullable annotations
…notations, and a null check.
akiraveliara
requested changes
Jul 15, 2025
Member
There was a problem hiding this comment.
please go through again and revert nullable annotations you added to value types. since value types require nullability to be annotated explicitly, the library is already built for and tested for NVT annotations being correct.
any such changes should be explicitly justified, ideally separate from this PR, because they are behavioural changes that need to be tested and not just annotations that make users' lives easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added nullable annotations to class fields/properties, as well as method parameters, and minor refactorings.
Details
A majority of this PR targets the task
Nullability-annotating the librariesfrom #1580, v5 Mega-Issue. There are a few changes that target the taskCleaning up code readability, such as renaming PITA variable names to better match what they represent.Simple examples include:
pldtopayloadbgn64toreadLongMagicretto a simplified version of the type name, likewebhookormessageNotes
I tried my best to be accurate, but I may have gone overboard in some data models. Please let me know if anything marked as nullable should not be, and I'll make the necessary adjustments to the PR.