upgrade permissions to 128-bit with ability to scale indefinitely #2152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VelvetToroyashi
approved these changes
Nov 8, 2024
Member
VelvetToroyashi
left a comment
VelvetToroyashi
left a comment
There was a problem hiding this comment.
GitHub makes a lot of this unfathomably abhorrent to actually look at, but I'm fond of the changes. I don't see anything major at first-glance, but I'm also partially sleep deprived.
Plerx2493
approved these changes
Nov 11, 2024
Member
Plerx2493
left a comment
Plerx2493
left a comment
There was a problem hiding this comment.
Looks good, although the bit math is a bit too high for me after work :when:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1969
requires .NET 9 - do not merge before .NET 9 is released
this pull request enables permissions to scale indefinitely by the change of a single constant (at 512 bits we should consider using 256-bit steps and Vector256 instead, but that'll be a problem for in several decades assuming Discord lives that long without ever changing the fundamentals of their permission system). the permission logic is efficient and well-tested. the naming for the container type may still change - do not consider the API laid out here final.
the minimum size for new permissions is 128-bit for simplicity, not because it's required yet, but it'll be required soon enough regardless, possibly even before a v5 release.