Skip to content

WIP: Remove unnecessary files#1439

Draft
Epicpkmn11 wants to merge 1 commit intoDS-Homebrew:masterfrom
Epicpkmn11:make-smaller
Draft

WIP: Remove unnecessary files#1439
Epicpkmn11 wants to merge 1 commit intoDS-Homebrew:masterfrom
Epicpkmn11:make-smaller

Conversation

@Epicpkmn11
Copy link
Copy Markdown
Member

@Epicpkmn11 Epicpkmn11 commented Apr 29, 2021 •
edited by lifehackerhansol
Loading

What's changed?

Note: Probably a bit broken at the moment, haven't made any code changes yet just making a start so I can make a PR to track what I'm planning

  • Remove 3dsmenu "loading" folder, it's not used
  • Remove rvid from default 3DS skin, it can be gotten from the twlmenu-extras version
    • Actually maybe this could be a GIF, that'd probably save quite a bit of space, might be too intense though, the splash GIFs can struggle and they're the only thing happening, it is only 256x56 at 25 fps though
  • Remove R4 and Acekard skins, they can be gotten seprately
    • I think it's probably fine to keep the dark and light DSi and 3DS skins as they're probably the most popular, imo the R4 skins aren't as needed
  • Remove usrcheat.dat files from flashcard loaders (is this fine? I assume so as TWiLight can't even use those cheats)
    • Are there more files that can be removed from those? Probably at least some of the fonts, those are quite large
  • Make Chinese (Simplified) and Korean fonts separate, the Default font works has everything TWiLight itself needs
    • Remove them
    • Add them to twlmenu-extras
  • Make Classic and Shop songs separate
    • Remove them
    • Add them to twlmenu-extras
    • Make music selectable separately from skins
    • Maybe add WAV support, it's like basically the same thing but with a header so we can know the frequency which would be helpful since the shop song is 22050 Hz
  • Maybe make 3DS, HBL, Saturn, and GBC themes into skins, they could still be included or (at least some) moved to twlmenu-extras
    • It'd be nice to make everything in those be theme.ini options so that any piece of those skins can be used with any other (ex. scrollbar and HBL bubbles) at least for now I'd most likely just add a theme = 3ds or so to the theme.ini are replace the ms().theme == 1 and such checks with that

Suggestions on other things to remove or if I'm doing too much are welcome. My goal here is mainly to remove things that are completely unused and cosmetic things that can easily be gotten separately without impacting functionality.

Where have you tested it?

  • Not yet

Pull Request status

  • This PR has been tested using the latest version of devkitARM and libnds.

@lifehackerhansol
Copy link
Copy Markdown
Contributor

lifehackerhansol commented Jul 21, 2021

flashcard loaders

So far I've cleaned it up a little bit. Still some going on, such as figuring out whether R4SDHC flashcart loader is even needed, whether the fonts should stay, etc. I'm going to test the fonts soon.

It does seem the font is not required for the Acekard loaders (and the R4 Ultra loader) so maybe that'll translate to the Wood loaders.

I also don't know how DSTWO works so that might be a while.

@lifehackerhansol
Copy link
Copy Markdown
Contributor

lifehackerhansol commented Sep 29, 2021

Removing the fonts actually works, and about 5 MB was reduced overall. I think I've removed everything possible for flashcart loaders, so I've marked it.

@lifehackerhansol
Copy link
Copy Markdown
Contributor

lifehackerhansol commented Mar 29, 2022 •
edited
Loading

Tried rebasing the PR. Apparently #1854 and #1855 removed everything that was changed in this PR. In fact, theoretically there is now no change in this PR.

I've checked off whatever was removed in said PRs for the checklist here.

So only thing left is the audio stuff.

@NightScript370
Copy link
Copy Markdown
Member

NightScript370 commented Jul 13, 2022

More flashcart loader work was done, as now more carts can be based on the same loader.

@NightScript370
Copy link
Copy Markdown
Member

NightScript370 commented Nov 9, 2023

Maybe add WAV support, it's like basically the same thing but with a header so we can know the frequency which would be helpful since the shop song is 22050 Hz

Hadn't this been done?

@RocketRobz
Copy link
Copy Markdown
Member

RocketRobz commented Nov 9, 2023

Maybe add WAV support, it's like basically the same thing but with a header so we can know the frequency which would be helpful since the shop song is 22050 Hz

Hadn't this been done?

Yeah, it has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Epicpkmn11 @lifehackerhansol @NightScript370 @RocketRobz