Skip to content

fix(router/twitter): fix twitter converstaion root post missing issue - #22963

Open
E1xP wants to merge 1 commit into
DIYgod:masterfrom
E1xP:fix/twitter-conversation
Open

fix(router/twitter): fix twitter converstaion root post missing issue#22963
E1xP wants to merge 1 commit into
DIYgod:masterfrom
E1xP:fix/twitter-conversation

Conversation

@E1xP

@E1xP E1xP commented Aug 8, 2026

Copy link
Copy Markdown

Involved Issue / 该 PR 相关 Issue

Close #22938

Example for the Proposed Route(s) / 路由地址示例

/twitter/user/KOMODO_Games_JP

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

This fix is try to contain the twitter conversation tweet post into the route /twitter/user.
As some twitter acount using the conversation to create post.
But currently the root post is filter due to not access the entries 'profile-conversation-'.

The change is adding 'profile-conversation-' to the getUserTweetsByID and filter the none root post info.

And sorry for the misformat pull request before.

@github-actions github-actions Bot added route auto: not ready to review Users can't get the RSS feed output according to automated testing results labels Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Successfully generated as following:

http://localhost:1200/twitter/user/KOMODO_Games_JP - Failed ❌ 
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/user/:id/:routeParams?
Full Route: /twitter/user/KOMODO_Games_JP
Node Version: v24.19.0
Git Hash: 8959c79a

@github-actions

github-actions Bot commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Auto Review

No clear rule violations found in the current diff. Previously reported issues (the self-reply filter change in getUserTweets and the TODO: comment prefixes) have been addressed.

@E1xP
E1xP force-pushed the fix/twitter-conversation branch from 8297d26 to 6916004 Compare August 8, 2026 07:19
@github-actions github-actions Bot removed the auto: not ready to review Users can't get the RSS feed output according to automated testing results label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Successfully generated as following:

http://localhost:1200/twitter/user/KOMODO_Games_JP - Failed ❌ 
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>ConfigNotFoundError: Twitter API is not configured
Route: /twitter/user/:id/:routeParams?
Full Route: /twitter/user/KOMODO_Games_JP
Node Version: v24.19.0
Git Hash: 9776580f

@github-actions github-actions Bot added the auto: not ready to review Users can't get the RSS feed output according to automated testing results label Aug 8, 2026
@E1xP

E1xP commented Aug 8, 2026

Copy link
Copy Markdown
Author

Had change the code base on the Auto Review.

@E1xP

E1xP commented Aug 9, 2026

Copy link
Copy Markdown
Author

The route test failure is due to the test enviroment not config the twitter auth key.
The local test is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto: not ready to review Users can't get the RSS feed output according to automated testing results route

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

Twitter user endpoint return nothing at special user

1 participant

@E1xP