add UniTask.AsValueTask for Unity#533
Merged
neuecc merged 3 commits intoCysharp:masterfrom Jan 24, 2024
Merged
Conversation
Member
|
This is because ValueTask was not part of the Unity standard, so there is no problem to include it now! |
Contributor
Author
|
I understand why it was only implemented in .NET Core! |
|
Rather than removing |
Contributor
Author
|
Removing I have confirmed that the compile error no longer occurs in the following three environments
Thank you! |
Member
|
thanks, merged and release soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #532
I moved
src/UniTask.NetCore/NetCore/UniTask.AsValueTask.cstosrc/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.AsValueTask.csand made some changes.I confirmed that the extension method works in Unity 2021.3 .NET Standard 2.1 and
UniTask.NetCoreTeststest was successful.I am not sure if this change is ok. Please give me your opinion.