PHP 8.4: E_STRICT deprecation#6802
Merged
SamMousa merged 4 commits intoCodeception:mainfrom Nov 29, 2024
Merged
Conversation
TavoNiievez
approved these changes
Nov 10, 2024
Contributor
Author
|
@Naktibalda @SamMousa Please let me know if I can assist to get this merged. It would be great to have a new Codeception release after this PR is merged. |
|
Any idea when next released is scheduled to benefit from this change at least? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates the
E_STRICTerror level constant.RFC: https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant
This PR removes the constant from the internal test suite and the default configuration.
For the error handler the constant is only used for PHP 8.3 or lower.
Furthermore, tests against PHP 8.4 are enabled in the CI.