Merge pull request #291 from CleanCut/release-env

sodul · web-flow · commit 9e9e5cfe8b0a · 2024-02-15T08:36:51.000-08:00
Set environment name for the releases
diff --git a/.github/workflows/release-test.yml b/.github/workflows/release-test.yml
@@ -9,7 +9,7 @@ jobs:
     name: Upload release to PyPI Test
     runs-on: ubuntu-latest
     environment:
-      name: pypi
+      name: release-test
       url: https://test.pypi.org/p/green
     permissions:
       id-token: write  # IMPORTANT: this permission is mandatory for trusted publishing
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -11,7 +11,7 @@ jobs:
     if: github.event_name == 'release'
     runs-on: ubuntu-latest
     environment:
-      name: pypi
+      name: release
       url: https://pypi.org/p/green
     permissions:
       id-token: write  # IMPORTANT: this permission is mandatory for trusted publishing
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 #### Date TBD
 
 # Version 4.0.1
-#### 14 Feb 2024
+#### 15 Feb 2024
 
 Note that we are explicitly flagging Python 3.12.1 as incompatible due to a regression
 that was fixed in 3.12.2.
diff --git a/release.md b/release.md
@@ -5,6 +5,6 @@ Steps to Release
 
 2. Push and merge to the main branch.
 
-3. Trigger the Release Test workflow in GitHub Actions. Optional but recommended.
+3. Trigger the Release Test workflow in GitHub Actions then approve the run on the release-test environment. Optional but recommended.
 
-4. Create a new release in GitHub with a tag that mirrors the version, the GH action will take care of the rest.
+4. Create a new release in GitHub with a tag that mirrors the version, the GH action will take care of the rest after beeing approved to run.
