Skip to content

Update cpp20 external#1117

Merged
dlyr merged 38 commits into
STORM-IRIT:release-candidatefrom
dlyr:update_cpp20_external
Apr 21, 2026
Merged

Update cpp20 external#1117
dlyr merged 38 commits into
STORM-IRIT:release-candidatefrom
dlyr:update_cpp20_external

Conversation

@dlyr
Copy link
Copy Markdown
Contributor

@dlyr dlyr commented Apr 13, 2026 •
edited
Loading

Pull Request Desription

Move to c++20 standard
Update most external to last released version
Eigen stay in 3.4 since there is some instabilities with 5

UPDATE the form below to describe your PR

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

  • What kind of change does this PR introduce?

    • bug fix
    • feature
    • docs update
    • other: update externals and move to c++20

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Change external version may have incidence on client code, as well as c++20

dlyr added 30 commits April 13, 2026 12:52
@dlyr
[examples] More enum, cleaner, in ParameterEditing.
4053a65
@dlyr
[external] Update QtNodes, skip build doc.
1c0f74e 
Since Sphinx config failed on my setup.
@dlyr
[external] Use master commit for QtNodes, waiting new release.
c37193a
@dlyr
[external] No shallow on qt nodes until tag release.
fe9678f
@dlyr
[external] Bump most external versions. Update corresponding code.
c5c9077
@dlyr
[external] Go back to eigen 3.4.1
8788c7e
@dlyr
[external] Update glm dir.
fd977a1
@dlyr
[core] set DLL_EXPORT visibility for g++/clang
07e5670
@dlyr
[gui] Rework on variable set enum management (wip?).
73bcf65
@dlyr
[gui] remove debug message.
29ba706
@dlyr
[cmake] Move find package in the windeplyqt function.
99bd83f 
Hence if the function is not called, no need to find qt packages.
@dlyr
[headless] Use update CLI11, use one header version.
fa1b226
@dlyr
[engine] Remove default struct ctor.
659e76a
@dlyr
Switch to c++ 20 (there are some cool helpers...)
ad500c3
@dlyr
[gui] Update lambda capture according to c++ 20.
1e7df08
@dlyr
[core] Fix missing math define for msvc (in pch).
7b66cc6
@dlyr
[gui] Use Qt's contains instead of std::find.
0e7716d 
Might fix recent compilation issue on mac.
@dlyr
[ci] Bump Qt version to last LTS 6.8.3.
4277411
@dlyr
[core] Fix cross return type.
8154e4c
@dlyr
[tests] Add Eigen openmesh specialization unittest.
5b217c8
@dlyr
[plugin] Delete empty source file.
e9c267b
@dlyr
[core] Do not overload eigen_assert macro.
7fa7e2d
@dlyr
[cmake] Coverage for both llvm and gcc (add env)
a833a70
@dlyr
[ci][cmake] Add llvm cov
71499e3
@dlyr
[engine] Move nested class out of function def, fix coverage.
d4e7438
@dlyr
[ci] Remove unused linux-clang option.
5074d9e
@dlyr
[cmake][examples] c++ 20 everywhere.
0771e68
@dlyr
[core][examples] Fix warnings form c++ 20.
4b87759
@dlyr
[core] More make type readable fixes (Eigen<Scalar -> Vector).
6e856cb
@dlyr
[core] Return plain string instead of ref in getAttribName.
25ce653
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 21.95122% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.49%. Comparing base (6a796b9) to head (dfcf3d6).
⚠️ Report is 40 commits behind head on release-candidate.

Files with missing lines Patch % Lines
examples/ParameterEditing/main.cpp 0.00% 24 Missing ⚠️
src/Gui/ParameterSetEditor/ParameterSetEditor.hpp 0.00% 20 Missing ⚠️
examples/DrawPrimitives/minimalapp.cpp 0.00% 12 Missing ⚠️
src/Gui/Viewer/RotateAroundCameraManipulator.cpp 0.00% 10 Missing ⚠️
examples/DrawPrimitives/main.cpp 0.00% 8 Missing ⚠️
src/Gui/Viewer/TrackballCameraManipulator.cpp 0.00% 8 Missing ⚠️
src/Gui/ParameterSetEditor/BasicUiBuilder.hpp 0.00% 5 Missing ⚠️
src/Gui/Viewer/FlightCameraManipulator.cpp 0.00% 5 Missing ⚠️
src/Engine/Scene/CameraManager.cpp 0.00% 2 Missing ⚠️
src/Gui/SelectionManager/SelectionManager.cpp 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@                  Coverage Diff                  @@
##           release-candidate    #1117      +/-   ##
=====================================================
+ Coverage              42.07%   44.49%   +2.41%     
=====================================================
  Files                    387      372      -15     
  Lines                  30144    28136    -2008     
=====================================================
- Hits                   12683    12519     -164     
+ Misses                 17461    15617    -1844
Flag Coverage Δ
integration 7.38% <3.25%> (+0.42%) ⬆️
unittests 42.70% <21.95%> (+2.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dlyr dlyr merged commit 151b23d into STORM-IRIT:release-candidate Apr 21, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlyr @MathiasPaulin