Open
Conversation
Rewrite compiler/parsing/fromSexpScript.sml to use mlsexp (Atom/Expr) from basis/pure instead of simpleSexp from HOL4's context-free examples. This is Phase 1 of eliminating simpleSexp from CakeML. Key changes: - Ancestor: mlsexp replaces simpleSexpParse - Holmakefile: INCLUDES basis/pure instead of HOL4 context-free - Encoding: SX_SYM/SX_NUM/SX_STR/SX_CONS replaced by Atom/Expr - listsexp xs = Expr xs (trivial, lists are native) - dstrip_sexp extracts tag + args from Expr (Atom tag :: args) - All roundtrip proofs (encoder/decoder bijection) updated - dstrip_sexp_SOME uses strlit nm form for efficient gvs resolution Co-Authored-By: Claude Opus 4.6 <[email protected]>
Use mlsexp$fromString instead of parse_sexp for sexp input parsing, and sexp_to_string instead of print_sexp for sexp output. Remove simpleSexpParse ancestor and formal-languages/context-free includes from compiler, scheme, and dafny Holmakefiles. Co-Authored-By: Claude Opus 4.6 <[email protected]>
…n files SexpProg (in basis/) already translates the mlsexp parser/printer to CakeML, so the translation files no longer need to translate simpleSexp's PEG parser, printer, or destructor functions. Remove ~300 lines of now-unnecessary code. Co-Authored-By: Claude Opus 4.6 <[email protected]>
dnezam
added
the
test failing
Contributor
|
In addition to the proof failure in |
Contributor
|
the sexp_parser failure is known, I just didn't want to fix it manually yet... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.