Skip to content

Add NoRules Disabler - #9052

Open
g-a-l-a-x-i-a wants to merge 3 commits into
CCBlueX:nextgenfrom
g-a-l-a-x-i-a:nextgen
Open

g-a-l-a-x-i-a wants to merge 3 commits into
CCBlueX:nextgenfrom
g-a-l-a-x-i-a:nextgen

Conversation

@g-a-l-a-x-i-a

Copy link
Copy Markdown

NoRules Full disabler

@liquidbounce-support-bot

Copy link
Copy Markdown
Contributor

Thanks for the PR! A few things a reviewer will likely flag:

  • Mappings/imports won't compile as-is. The codebase is on Yarn mappings, so this needs net.minecraft.network.packet.c2s.play.PlayerMoveC2SPacket (.PositionAndOnGround / .Full) and onGround rather than the Mojang-mapped ServerboundMovePlayerPacket/isOnGround. network also isn't imported here.
  • Rotations are dropped globally while enabled. Every outgoing PosRot is replaced with a rotation-less Pos, so nothing rotation-dependent (KillAura, Scaffold, block interaction) reports a yaw/pitch to the server any more. LookAndOnGround also still goes through untouched, so the packet stream ends up inconsistent. Worth explaining why that's the intended behaviour for this target.
  • The PR body doesn't say what "NoRules" is — which network/anticheat, and how the bypass was verified. Other disabler entries are tied to a concrete target, and most gate themselves on the relevant conditions instead of running unconditionally.
  • Docs impact: new Disabler entries should get a row on the Disabler page in the Documentation repo.

🤖 Automated support reply — a human maintainer will review if this doesn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants