Skip to content

add support for php7 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vdloo wants to merge 2 commits into from
Closed

add support for php7 #3

vdloo wants to merge 2 commits into from

Conversation

@vdloo
Copy link
Member

@vdloo vdloo commented Apr 4, 2016

new fcgi_request struct definition fastcgi.c

wget https://raw.githubusercontent.com/ByteInternet/php/hypernode-7.0/main/fastcgi.c

and replace

#include "fastcgi.h"

with

#include "fastcgi.c"

we could probably do this with preprocessor macros instead of copying the entire src dir but I don't know how

looks like:

Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: tcp_info.tcp_state is 8, TCP_CLOSE_WAIT_STATE is 8
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: Terminated request GET php7.hypernode.local/index.php because client at 10.0.3.1 is already gone
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: tcp_info.tcp_state is 8, TCP_CLOSE_WAIT_STATE is 8
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: Terminated request GET php7.hypernode.local/index.php because client at 10.0.3.1 is already gone
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: tcp_info.tcp_state is 8, TCP_CLOSE_WAIT_STATE is 8
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: Terminated request GET php7.hypernode.local/index.php because client at 10.0.3.1 is already gone
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: tcp_info.tcp_state is 8, TCP_CLOSE_WAIT_STATE is 8
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: Terminated request GET php7.hypernode.local/index.php because client at 10.0.3.1 is already gone
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: tcp_info.tcp_state is 8, TCP_CLOSE_WAIT_STATE is 8
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: Terminated request GET php7.hypernode.local/index.php because client at 10.0.3.1 is already gone
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: tcp_info.tcp_state is 8, TCP_CLOSE_WAIT_STATE is 8
Apr  4 15:08:59 2a1186-php7-magweb-vgr ool www: Terminated request GET php7.hypernode.local/index.php because client at 10.0.3.1 is already gone

@vdloo
add support for php7
c26035a 
new fcgi_request struct definition fastcgi.c
@vdloo vdloo mentioned this pull request Apr 4, 2016
Closed
@allardhoeve
Copy link
Contributor

allardhoeve commented Apr 4, 2016

Goed gevonden!

allardhoeve
allardhoeve reviewed Apr 5, 2016
View reviewed changes
php-7.0/hypernode-20160309.1/hypernode.c Outdated
#include "main/php_syslog.h"

#include "SAPI.h"
#include "fastcgi.c"
Copy link
Contributor

@allardhoeve allardhoeve Apr 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In plaats van alles kopieren, misschien dit?

#if ZEND_MODULE_API_NO < 20151012
#include "fastcgi.h"
#else
#include "main/fastcgi.h"
#endif

@vdloo
Copy link
Member Author

vdloo commented Mar 8, 2017

don't think we need this anymore for xenial

@vdloo vdloo closed this Mar 8, 2017
@vdloo vdloo deleted the php-hypernode-for-php7 branch March 8, 2017 15:56
vdloo added a commit that referenced this pull request Jun 8, 2021
@vdloo
php8.0 compatibility
5e01749 
see related #3
@vdloo vdloo mentioned this pull request Jun 8, 2021
Merged
vdloo added a commit that referenced this pull request Jun 9, 2021
@vdloo
php8.0 compatibility
93c9ce2 
see related #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vdloo @allardhoeve