Skip to content

php8.0 compatibility #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdloo merged 1 commit into from
Jun 9, 2021
Merged

php8.0 compatibility #18

vdloo merged 1 commit into from
Jun 9, 2021

Conversation

@vdloo
Copy link
Member

@vdloo vdloo commented Jun 8, 2021 •
edited
Loading

see related #3

configure: WARNING: unrecognized options: --disable-silent-rules, --disable-maintainer-mode, --disable-dependency-tracking
touch configure-5.6-stamp
dh override_dh_auto_configure --with php
make[1]: Leaving directory '/build/php-hypernode-20200721.074350'
   debian/rules override_dh_auto_build
make[1]: Entering directory '/build/php-hypernode-20200721.074350'
dh_auto_build --sourcedirectory=build-8.0
	cd build-8.0 && make -j1
make[2]: Entering directory '/build/php-hypernode-20200721.074350/build-8.0'
/bin/bash /build/php-hypernode-20200721.074350/build-8.0/libtool --mode=compile cc -I. -I/build/php-hypernode-20200721.074350/build-8.0 -I/build/php-hypernode-20200721.074350/build-8.0/include -I/build/php-hypernode-20200721.074350/build-8.0/main -I/build/php-hypernode-20200721.074350/build-8.0 -I/usr/include/php/20200930 -I/usr/include/php/20200930/main -I/usr/include/php/20200930/TSRM -I/usr/include/php/20200930/Zend -I/usr/include/php/20200930/ext -I/usr/include/php/20200930/ext/date/lib  -Wdate-time -D_FORTIFY_SOURCE=2 -DHAVE_CONFIG_H  -g -O2 -fdebug-prefix-map=/build/php-hypernode-20200721.074350=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic    -c /build/php-hypernode-20200721.074350/build-8.0/hypernode.c -o hypernode.lo 
libtool: compile:  cc -I. -I/build/php-hypernode-20200721.074350/build-8.0 -I/build/php-hypernode-20200721.074350/build-8.0/include -I/build/php-hypernode-20200721.074350/build-8.0/main -I/build/php-hypernode-20200721.074350/build-8.0 -I/usr/include/php/20200930 -I/usr/include/php/20200930/main -I/usr/include/php/20200930/TSRM -I/usr/include/php/20200930/Zend -I/usr/include/php/20200930/ext -I/usr/include/php/20200930/ext/date/lib -Wdate-time -D_FORTIFY_SOURCE=2 -DHAVE_CONFIG_H -g -O2 -fdebug-prefix-map=/build/php-hypernode-20200721.074350=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -c /build/php-hypernode-20200721.074350/build-8.0/hypernode.c  -fPIC -DPIC -o .libs/hypernode.o
/build/php-hypernode-20200721.074350/build-8.0/hypernode.c: In function 'zm_activate_hypernode':
/build/php-hypernode-20200721.074350/build-8.0/hypernode.c:132:24: error: dereferencing pointer to incomplete type 'fcgi_request' {aka 'struct _fcgi_request'}
  if (getsockopt(request->fd, IPPROTO_TCP, TCP_INFO, (void*)&tcp_info, (socklen_t*)&tcp_info_length)) {
                        ^~
/build/php-hypernode-20200721.074350/build-8.0/hypernode.c:141:59: error: expected ')' before 'TSRMLS_CC'
   http_host = sapi_getenv("HTTP_HOST", strlen("HTTP_HOST") TSRMLS_CC);
                                                           ^~~~~~~~~~
                                                           )
/build/php-hypernode-20200721.074350/build-8.0/hypernode.c:142:65: error: expected ')' before 'TSRMLS_CC'
   remote_addr = sapi_getenv("REMOTE_ADDR", strlen("REMOTE_ADDR") TSRMLS_CC);
                                                                 ^~~~~~~~~~
                                                                 )
At top level:
/build/php-hypernode-20200721.074350/build-8.0/hypernode.c:92:13: warning: 'php_hypernode_init_globals' defined but not used [-Wunused-function]
 static void php_hypernode_init_globals(zend_hypernode_globals *hypernode_globals)
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/php-hypernode-20200721.074350/build-8.0/hypernode.c:48:12: warning: 'le_hypernode' defined but not used [-Wunused-variable]
 static int le_hypernode;
            ^~~~~~~~~~~~
make[2]: *** [Makefile:208: hypernode.lo] Error 1
make[2]: Leaving directory '/build/php-hypernode-20200721.074350/build-8.0'
dh_auto_build: cd build-8.0 && make -j1 returned exit code 2
make[1]: *** [/usr/share/dh-php/pkg-pecl.mk:67: build-8.0-stamp] Error 2

Also see zephir-lang/zephir#1865

Examples of removal from the php team here, there and over there

https://github.com/php/php-src/blob/master/UPGRADING.INTERNALS
php/php-src@e05d230
php/php-src@a1fd706
php/php-src@9977bdf

this can be built like:

# apt-get install php8.0-dev
# cd php-hypernode/hypernode-src
# phpize
# ./configure

(without the whole gbp buildpackage stuff)

@vdloo vdloo force-pushed the php80-compatibility branch from 5e01749 to 93c9ce2 Compare June 9, 2021 19:11
@vdloo vdloo merged commit 9c4aedc into master Jun 9, 2021
@vdloo vdloo deleted the php80-compatibility branch June 9, 2021 19:13
@vdloo
Copy link
Member Author

vdloo commented Jun 9, 2021 

root@j6yt5z-vdloo-magweb-cmbl /tmp/php-hypernode # dpkg -i php-hypernode_20200721.074350_amd64.deb
(Reading database ... 85681 files and directories currently installed.)
Preparing to unpack php-hypernode_20200721.074350_amd64.deb ...
WARNING: Module hypernode ini file doesn't exist under /etc/php/8.0/mods-available
Unpacking php-hypernode (20200721.074350) over (20200721.074350) ...
Setting up php-hypernode (20200721.074350) ...
root@j6yt5z-vdloo-magweb-cmbl /tmp/php-hypernode # dpkg -L php-hypernode
/.
/etc
/etc/php
/etc/php/5.6
/etc/php/5.6/mods-available
/etc/php/5.6/mods-available/hypernode.ini
/etc/php/7.0
/etc/php/7.0/mods-available
/etc/php/7.0/mods-available/hypernode.ini
/etc/php/7.1
/etc/php/7.1/mods-available
/etc/php/7.1/mods-available/hypernode.ini
/etc/php/7.2
/etc/php/7.2/mods-available
/etc/php/7.2/mods-available/hypernode.ini
/etc/php/7.3
/etc/php/7.3/mods-available
/etc/php/7.3/mods-available/hypernode.ini
/etc/php/7.4
/etc/php/7.4/mods-available
/etc/php/7.4/mods-available/hypernode.ini
/etc/php/8.0
/etc/php/8.0/mods-available
/etc/php/8.0/mods-available/hypernode.ini
/usr
/usr/lib
/usr/lib/php
/usr/lib/php/20131226
/usr/lib/php/20131226/hypernode.so
/usr/lib/php/20151012
/usr/lib/php/20151012/hypernode.so
/usr/lib/php/20160303
/usr/lib/php/20160303/hypernode.so
/usr/lib/php/20170718
/usr/lib/php/20170718/hypernode.so
/usr/lib/php/20180731
/usr/lib/php/20180731/hypernode.so
/usr/lib/php/20190902
/usr/lib/php/20190902/hypernode.so
/usr/lib/php/20200930
/usr/lib/php/20200930/hypernode.so
/usr/share
/usr/share/doc
/usr/share/doc/php-hypernode
/usr/share/doc/php-hypernode/changelog.gz

vdloo added a commit that referenced this pull request Nov 16, 2021
@vdloo
allow building php-hypernode for php 8.1
4e220bf 
like https://github.com/ByteInternet/php-hypernode/pull/17/files but PHP 8.1 this time

also see related #18
@vdloo vdloo mentioned this pull request Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vdloo