Descriptions: Improved empty field handling, reduces whitespace

ssddanbrown · ssddanbrown · commit 229a99ba24d7 · 2026-02-20T14:22:54.000Z
For #5724
diff --git a/app/Entities/Tools/EntityHtmlDescription.php b/app/Entities/Tools/EntityHtmlDescription.php
@@ -50,6 +50,11 @@ public function getHtml(bool $raw = false): string
             return $html;
         }
 
+        $isEmpty = empty(trim(strip_tags($html)));
+        if ($isEmpty) {
+            return '<p></p>';
+        }
+
         return HtmlContentFilter::removeActiveContentFromHtmlString($html);
     }
 
diff --git a/resources/views/form/description-html-input.blade.php b/resources/views/form/description-html-input.blade.php
@@ -1,7 +1,7 @@
 <textarea component="wysiwyg-input"
           option:wysiwyg-input:text-direction="{{ $locale->htmlDirection() }}"
           id="description_html" name="description_html" rows="5"
-          @if($errors->has('description_html')) class="text-neg" @endif>@if(isset($model) || old('description_html')){{ old('description_html') ?? $model->descriptionInfo()->getHtml() }}@endif</textarea>
+          @if($errors->has('description_html')) class="text-neg" @endif>@if(isset($model) || old('description_html')){{ old('description_html') ?? $model->descriptionInfo()->getHtml() }}@else{{ '<p></p>' }}@endif</textarea>
 @if($errors->has('description_html'))
     <div class="text-neg text-small">{{ $errors->first('description_html') }}</div>
 @endif
diff --git a/tests/Entity/BookTest.php b/tests/Entity/BookTest.php
@@ -278,4 +278,25 @@ public function test_show_view_displays_description_if_no_description_html_set()
         $resp = $this->asEditor()->get($book->getUrl());
         $resp->assertSee("<p>My great<br>\ndescription<br>\n<br>\nwith newlines</p>", false);
     }
+
+    public function test_description_with_only_br_tags_results_in_empty_p_tag_used_on_show()
+    {
+        $descriptions = [
+            '<p><br></p>',
+            '<p><br><br><br><br></p>',
+            '<p><br><br><br></p><h1><br><br><br><br><br></h1>',
+        ];
+        $book = $this->entities->book();
+        $this->asEditor();
+
+        foreach ($descriptions as $descriptionTestCase) {
+            $book->description_html = $descriptionTestCase;
+            $book->save();
+
+            $resp = $this->get($book->getUrl());
+            $html = $this->withHtml($resp);
+            $descriptionHtml = $html->getInnerHtml('.book-content > div.text-muted:first-child');
+            $this->assertEquals('<p></p>', $descriptionHtml);
+        }
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,11 @@ public function getHtml(bool $raw = false): string`
`50`	`50`	`return $html;`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ $isEmpty = empty(trim(strip_tags($html)));`
	`54`	`+ if ($isEmpty) {`
	`55`	`+ return '<p></p>';`
	`56`	`+ }`
	`57`	`+`
`53`	`58`	`return HtmlContentFilter::removeActiveContentFromHtmlString($html);`
`54`	`59`	`}`
`55`	`60`