Fix TimePicker to respect custom Width property #20507
Merged
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Allows developers to set a custom
WidthonTimePickerwithout the content overflowing. Currently, the internalButtonhas a hardcodedMinWidthfromTimePickerThemeMinWidth(242px) that cannot be overridden, preventing compact TimePickers in narrower layouts.I made a PR to fix the
DatePickerhere, but I forgot to also updateTimePicker. This PR is identical, except it addresses TimePicker instead.What is the current behavior?
When setting
Width="200"on a TimePicker, the content overflows because the internal Button enforcesMinWidth=242regardless of the control's Width setting.What is the updated/expected behavior with this PR?
Developers can now create compact TimePickers by setting
MinWidth="0":Default behavior is unchanged - TimePickers without explicit MinWidth still use the theme default (242px).
How was the solution implemented?
This allows the Button to shrink when the TimePicker's MinWidth is overridden, while maintaining backward compatibility.
How to test this new behavior:
Add to
samples/ControlCatalog/Pages/DateTimePickerPage.xaml:Workaround (for developers waiting for this fix)
Until this PR is merged, you can override the theme resources locally:
Breaking changes
None
Obsoletions / Deprecations
None