Merged
Conversation
danpetry
reviewed
Sep 5, 2024
cbouss
reviewed
Sep 6, 2024
cbouss
reviewed
Sep 6, 2024
recipe/meta.yaml
Outdated
| @@ -1,7 +1,7 @@ | |||
| {% set version = "18.18.2" %} | |||
| {% set version = "20.9.0" %} | |||
There was a problem hiding this comment.
The latest 20 version is 20.17.0: https://github.com/nodejs/node/tree/v20.17.0
Author
There was a problem hiding this comment.
I added adjustments to solve nodejs/node#52223.
And updated the install.py command as $PYTHON tools/install.py install --dest-dir ${PREFIX} --prefix ''
danpetry
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destination channel: main
Links
Explanation of changes:
-j${CPU_COUNT}on Unix platformslibuvto build as it's a bootstrap dependency in js2c starting with 20.3, see tools: port js2c.py to C++ nodejs/node#46997libuv 1.48inhostbecause of newuv_pipe_bind2anduv_pipe_connect2methodsNotes: