Skip to content

Some of the exec arguments are not escaped #661

Description

@bohwaz

m_bro.php line 1048:
passthru("/bin/tar -cZ -C " . getuserpath() . "/" . $mem->user["login"] . "/ $d");

And more in the same file, including:

if (exec("/bin/tar cvf - " . escapeshellarg(getuserpath() . "/") . "| gzip -9c > " . escapeshellarg($dir . "/" . $mem->user['login'] . "_html_" . $timestamp . ".tar.gz")))

Also in src/alternc_fix_opendkim.php:
passthru("opendkim-genkey -r -d ".$c["domaine"]." -s alternc 2>&1");

Other code files with unescaped execs:

  • src/spoolsize.php
  • src/alternc-check
  • bureau/class/m_ssl.php

This probably cannot lead to an exploit as those variables have (probably?) been checked before being saved in database, but it is still bad practice to use unescaped parameters.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Status
    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions