[O2-1977][CMake](fix) Filter out macros in build directory if any#5241
Merged
ktf merged 1 commit intoAliceO2Group:devfrom Jan 20, 2021
Merged
[O2-1977][CMake](fix) Filter out macros in build directory if any#5241ktf merged 1 commit intoAliceO2Group:devfrom
ktf merged 1 commit intoAliceO2Group:devfrom
Conversation
ktf
approved these changes
Jan 20, 2021
Member
|
Apparently this is again an issue. See https://alice.its.cern.ch/jira/browse/O2-1896. Could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where the build directory is created under the source one, the
o2_get_list_of_macroswas picking some macros from the build directory, which then theo2_report_non_tested_macrosreported as missing.