Change factory methods to class methods#103
Merged
OrangeTux merged 1 commit intoJul 27, 2020
Merged
Conversation
OrangeTux
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of declaring the
create_from_request_pduandcreate_from_response_pdufactory methods as@staticmethod, use@classmethod. Then the class is passed to the method as theclsparameter, which can be used to instantiate an instance, rather than hardcoding the class name.This allows the function classes to be subclassed without having to reimplement the factory methods just to change the class name.
Also fixes up some comments that were incorrect.