Support the required flag on resource properties (Discovery and Swagger)#41
Merged
clementdenis merged 1 commit intomasterfrom Sep 16, 2019
Merged
Support the required flag on resource properties (Discovery and Swagger)#41clementdenis merged 1 commit intomasterfrom
clementdenis merged 1 commit intomasterfrom
Conversation
clementdenis
force-pushed
the
required_resource_field
branch
from
ea958f4 to
f009e19
Compare
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
============================================
+ Coverage 82.19% 82.24% +0.05%
- Complexity 1845 1855 +10
============================================
Files 158 158
Lines 6672 6692 +20
Branches 880 886 +6
============================================
+ Hits 5484 5504 +20
Misses 866 866
Partials 322 322
Continue to review full report at Codecov.
|
llbrt
approved these changes
Sep 10, 2019
llbrt
left a comment
llbrt
left a comment
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
endpoints-framework/src/test/java/com/google/api/server/spi/config/model/SchemaRepositoryTest.java, line 282 at r1 (raw file):
resrouce
resource
clementdenis
force-pushed
the
required_resource_field
branch
from
f009e19 to
d2c4455
Compare
llbrt
approved these changes
Sep 11, 2019
llbrt
left a comment
llbrt
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is