Add missing comparison cases for new builtin types#6208
Merged
Conversation
pchiusano
approved these changes
Mar 27, 2026
pchiusano
approved these changes
Mar 27, 2026
pchiusano
left a comment
pchiusano
left a comment
Member
There was a problem hiding this comment.
Looks fine though is it easy enough to add regression test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes errors that would occur if you tried to use equality or comparison on a few builtin types.
The implementation is a big diagonal list of all the cases with a catch-all for the off diagonal, so unfortunately there are no automatic complaints when new cases are added. Maybe there's some way to catch these better, but for the time being I've just added the missing cases.
Fixes #6201