Skip to content

fix: [Workflow Tools] Simple Agents cannot add workflow tools.#4977

Merged
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_simple_application
Mar 30, 2026
Merged

fix: [Workflow Tools] Simple Agents cannot add workflow tools.#4977
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_simple_application

Conversation

@shaohuzhang1
Copy link
Copy Markdown
Contributor

fix: [Workflow Tools] Simple Agents cannot add workflow tools.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 30, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit c4d0f1c into v2 Mar 30, 2026
3 checks passed
<ToolDialog ref="toolDialogRef" @refresh="submitToolDialog" tool_type="CUSTOM,WORKFLOW" />
<ToolDialog ref="skillToolDialogRef" @refresh="submitSkillToolDialog" tool_type="SKILL" />
<ApplicationDialog ref="applicationDialogRef" @refresh="submitApplicationDialog" />
</div>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the @refresh attribute in the ToolDialog component where you have provided two values ("CUSTOM", "WORKFLOW") instead of a comma-separated list. The correct syntax requires commas to separate multiple values. Here's the corrected line:

-<ToolDialog ref="toolDialogRef" @refresh="submitToolDialog" tool_type="CUSTOM,WORKFLOW" />
+<ToolDialog ref="toolDialogRef" @refresh="submitToolDialog" tool_type="CUSTOM,WORKFLOW"/>

Additionally, there are no other significant issues or optimizations needed at this time based on the given code snippet.

@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_simple_application branch March 30, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant