Skip to content

Clean up twisted.trial.runner #11692

Description

@exarkun

Is your feature request related to a problem? Please describe.

twisted.trial.runner has some pretty cruft old stuff in it:

  • It has an implicit interface with debuggers
  • It manually implements resource allocation/cleanup for log files and the working directory
  • TrialRunner has a dozen or more attributes manually defined and of poorly document types
  • There are few type annotations
  • There is loooong-since deprecated support for reporters with no done method
  • The test suite involves monkey-patching implementation details to observe various side-effects
  • The test suite involves monkey-patching implementation details to fix unexplained bugs which apparently no longer exist

All of this stuff gets in the way of trying to implement new features like #11671 . Let's start to clean it up.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions