Fix DataSourceUtils inconsistent exception handling#28669
Closed
kevin0x90 wants to merge 1 commit intospring-projects:5.3.xfrom
Closed
Fix DataSourceUtils inconsistent exception handling#28669kevin0x90 wants to merge 1 commit intospring-projects:5.3.xfrom
kevin0x90 wants to merge 1 commit intospring-projects:5.3.xfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Jun 21, 2022
Member
snicoll
left a comment
snicoll
left a comment
There was a problem hiding this comment.
Thanks for the PR but I don't think we should be changing the nested cause the way you suggest.
spring-jdbc/src/main/java/org/springframework/jdbc/datasource/DataSourceUtils.java
Outdated
Show resolved
Hide resolved
snicoll
added
the
status: waiting-for-feedback
sbrannen
added
in: data
kevin0x90
force-pushed
the
bugfix/gh-28258
branch
2 times, most recently
from
fb24abf to
e291a4d
Compare
Align IllegalStateException with SQLException handling and propagate the original exception Closes spring-projectsgh-28258
kevin0x90
force-pushed
the
bugfix/gh-28258
branch
from
e291a4d to
094e9ec
Compare
snicoll
removed
the
status: waiting-for-triage
snicoll
pushed a commit
that referenced
this pull request
Jun 23, 2022
Align IllegalStateException with SQLException handling and propagate the original exception. See gh-28669 Co-authored-by: Christoph Mies <[email protected]>
snicoll
added a commit
that referenced
this pull request
Jun 23, 2022
Member
|
Good stuff, thanks @kevin0x90 and @Suthman. |
Contributor
Author
|
Thanks for accepting our small contribution @snicoll |
izeye
added a commit
to izeye/spring-framework
that referenced
this pull request
Jun 30, 2022
sbrannen
pushed a commit
that referenced
this pull request
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align IllegalStateException with SQLException handling since IllegalState is only handled internally and the public facing Exception remains unchanged in either way.
Closes gh-28258