Tools: add PHPUnit Polyfills#503
Merged
shivammathur merged 1 commit intoshivammathur:developfrom Sep 20, 2021
Merged
Conversation
shivammathur
requested changes
Sep 20, 2021
Owner
shivammathur
left a comment
shivammathur
left a comment
There was a problem hiding this comment.
Please remove dist/index.js.bak file from the PR.
jrfnl
force-pushed
the
feature/tools-add-phpunit-polyfills
branch
from
2fecd25 to
2c8682d
Compare
Contributor
Author
|
Yikes! Sorry about that, not sure how that got in there as I have a git global ignore set up for those type of files... Either way, should be fixed now. |
shivammathur
approved these changes
Sep 20, 2021
Owner
|
@jrfnl Thanks! |
Contributor
Author
|
Thanks @shivammathur ! |
1 task
Contributor
Author
|
Integration test:
|
Contributor
Author
|
FYI: I've added an FAQ section to the README for the PHPUnit Polyfills about using it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: 🎉 New Feature
about: Add a new feature
labels: enhancement
A Pull Request should be associated with a Discussion.
Fixes #502
Description
This PR adds support for the PHPUnit Polyfills tool via the
toolsinput to setup-php.I have added a test to the
linuxtest and a second test with a specific version to thedarwintest.npm run formatbefore the commit.npm run lintbefore the commit.npm run releasebefore the commit.npm testreturns with no unit test errors and all code covered.Note: running these scripts, automatically added two unrelated changes to the PR, which I have manually removed (had to disable the
pre-commithook to do so). The changes were topackage-lock.jsonand todist/index.js. Not sure what's going on there.