Ensure parameter defaults are deoptimized#4515
Merged
lukastaegert merged 1 commit intomasterfrom May 29, 2022
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4514_deopt-parameter-defaultsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4515 +/- ##
==========================================
- Coverage 98.78% 98.74% -0.04%
==========================================
Files 208 208
Lines 7431 7437 +6
Branches 2120 2124 +4
==========================================
+ Hits 7341 7344 +3
Misses 34 34
- Partials 56 59 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4514
Description
Currently, we do not deoptimize parameter default values, which means we do not track deoptimizations or calls. This fixes it. See the linked issue for an example.