Fixed seeking to an L frame in a GIF#6576
Merged
hugovk merged 3 commits intopython-pillow:mainfrom Oct 18, 2022
Merged
Conversation
radarhere
changed the title
radarhere
changed the title
Member
Author
|
I've added a commit to address #6610 (comment) That comment found a GIF where on a later frame, the palette is "not needed" because the frame is grayscale. The problem is that Pillow then concludes that since there isn't a palette, it should fallback to the global palette. Pillow/src/PIL/GifImagePlugin.py Lines 275 to 301 in 243402e This is incorrect, as the frame is specifying custom palette behaviour, it's just that custom behaviour is to have a grayscale palette. |
radarhere
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6571
When pasting an L frame onto an RGB(A) GIF, convert the frame to RGB(A) first.
The test image was created using a modified Pillow, so that there is no global palette, and the image is comprised of a frame with a palette, and then two frames without. This means that the first frame is P mode, the second is L mode, combining to make RGB, and then there is an L mode frame pasted onto that RGB frame.