Block tile TIFF tags when saving#5839
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Nov 21, 2021
Merged
Conversation
Contributor
|
I haven't checked this - so Pillow never ever writes out tiles ATM, even when using libtiff? LGTM otherwise |
Contributor
|
I ask because the alternative could be: if you detect (existing?) tile-based tags, one could force libtiff writing and remove the stripe-based ones instead, so you can potentially keep the original data arrangement? |
Member
Author
|
When saving, whether using libtiff or not, strip tags are always set. In encoding TIFF using libtiff, you can see a call to And for another opinion, #672 (comment)
|
Contributor
|
Indeed, so this PR is a "must have" then. 👍 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5838
It is suggested in that issue that Pillow should automatically remove tile TIFF tags - rather than having both tile and strip tags saved to the same image.
So this PR removes TILEWIDTH, TILELENGTH, TILEOFFSETS and TILEBYTECOUNTS.