Fix detecting file as directory on zOS issue #8051#8052
Merged
acozzette merged 3 commits intoprotocolbuffers:masterfrom Nov 17, 2020
mahdi-hm:master
Merged
Fix detecting file as directory on zOS issue #8051#8052acozzette merged 3 commits intoprotocolbuffers:masterfrom mahdi-hm:master
acozzette merged 3 commits intoprotocolbuffers:masterfrom
mahdi-hm:master
Conversation
|
@mahdi-hosseini-moghaddam Thank you for sending this fix, but I think the one problem is that Windows doesn't seem to support the |
Contributor
Author
I didn't know that, Thank you for your comment. I will update that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sys/stat.h provides macros like S_ISDIR to test for a directory. The macro S_IFDIR should not be used in this way since it has different result on zOS(Always detecting file as directory as a consequence).