Fix HTML multiline comments bug (#246)#262
Merged
quantizor merged 1 commit intoquantizor:masterfrom Sep 12, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 99.47% 99.21% -0.26%
==========================================
Files 1 1
Lines 382 383 +1
Branches 63 63
==========================================
Hits 380 380
- Misses 2 3 +1
Continue to review full report at Codecov.
|
Owner
|
@eragon512 Can you just inline the regex? (https://github.com/johno/strip-html-comments/blob/master/index.js#L8) We don't need the extra bytes from the "is string" check |
Contributor
Author
|
@probablyup I have inlined the regex, could you take a look? |
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #246