Skip to content

Backport "Support TS4.9 satisfies operator (#13764)"#13783

Merged
fisker merged 11 commits intoprettier:mainfrom
sosukesuzuki:backport-satisfies-2
Nov 4, 2022
Merged

Backport "Support TS4.9 satisfies operator (#13764)"#13783
fisker merged 11 commits intoprettier:mainfrom
sosukesuzuki:backport-satisfies-2

Conversation

@sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Nov 2, 2022 •
edited
Loading

Description

Backports #13381 and #13733
This is a first step of backporting satisfies (#13764 (comment))

Checklist

✨Try the playground for this PR✨

@sosukesuzuki sosukesuzuki changed the title Backport #13381 and #13733 Backport TypeScript parsers update Nov 2, 2022
@sosukesuzuki sosukesuzuki marked this pull request as ready for review November 3, 2022 06:55
@sosukesuzuki sosukesuzuki requested a review from fisker November 3, 2022 06:55
@sosukesuzuki
Copy link
Contributor Author

sosukesuzuki commented Nov 3, 2022

I'll investigate why CI is failing...

@fisker
Copy link
Member

fisker commented Nov 3, 2022 •
edited
Loading

Shouldn't this diff be empty? https://github.com/prettier/prettier/compare/next...sosukesuzuki:prettier:backport-satisfies-2.diff

@fisker
Copy link
Member

fisker commented Nov 3, 2022

Because next not rebased?

@sosukesuzuki
Copy link
Contributor Author

sosukesuzuki commented Nov 3, 2022 •
edited
Loading

Shouldn't this diff be empty?

@fisker Why? Ah I got what do you mean. But I'm not sure why.

@sosukesuzuki

This comment was marked as resolved.

Sign in to view
@fisker fisker mentioned this pull request Nov 3, 2022
Closed
4 tasks
@sosukesuzuki sosukesuzuki changed the title Backport TypeScript parsers update Backport satisfies Nov 3, 2022
@ngregory-rbi
Copy link

ngregory-rbi commented Nov 3, 2022

Hello :) Please merge this in if and when you can :)

@fisker fisker changed the title Backport satisfies Backport "Support TS4.9 satisfies operator (#13764)" Nov 4, 2022
@fisker fisker merged commit ff0529a into prettier:main Nov 4, 2022
@fisker
Copy link
Member

fisker commented Nov 4, 2022 •
edited
Loading

@sosukesuzuki You changed this line in this PR, right? cccedf4 (#9583)

@sosukesuzuki
Copy link
Contributor Author

sosukesuzuki commented Nov 4, 2022

@sosukesuzuki You changed this line in this PR, right? cccedf4 (#9583)

Yes, I forgot to fix this in the original PR.

@sosukesuzuki sosukesuzuki deleted the backport-satisfies-2 branch November 4, 2022 04:16
@fisker
Copy link
Member

fisker commented Nov 4, 2022

Can you commit this change to next?

@sosukesuzuki
Copy link
Contributor Author

sosukesuzuki commented Nov 4, 2022

Yes

@sosukesuzuki sosukesuzuki mentioned this pull request Nov 4, 2022
Merged
2 tasks
@ngregory-rbi
Copy link

ngregory-rbi commented Nov 4, 2022

thanks for the merge :) just curious though, will this be included in a new mainline release 2.x.x soon?

@sosukesuzuki
Copy link
Contributor Author

sosukesuzuki commented Nov 4, 2022

This PR is only supported by the babel-ts parser; to make it also supported by the typescript parser, we need to wait typescript-eslint/typescript-eslint#5716 and typescript-eslint/typescript-eslint#5717 to be merge to typescript-eslint.

@sosukesuzuki sosukesuzuki mentioned this pull request Nov 6, 2022
Merged
4 tasks
sosukesuzuki pushed a commit that referenced this pull request Nov 6, 2022
Add changelog for #13783 (#13811)
520dbcd 
* Add changelog

* Fix
@kachkaev kachkaev added this to the 2.8 milestone Nov 16, 2022
@kachkaev kachkaev mentioned this pull request Nov 16, 2022
Closed
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 4, 2024
@medikoo
Backport "Support TS4.9 satisfies operator (prettier#13764)" (prett…
a69560c 
…ier#13783)
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 4, 2024
@medikoo
Add changelog for prettier#13783 (prettier#13811)
f72d0b4 
* Add changelog

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisker fisker Awaiting requested review from fisker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

4 participants

@sosukesuzuki @fisker @ngregory-rbi @kachkaev