Support global configuration for applying sql provider type when omit on annotation#1951
Merged
kazuki43zoo merged 3 commits intomybatis:masterfrom Jun 7, 2020
Merged
Conversation
Related with mybatisgh-1951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to support a global configuration for applying sql provider type when omit
typeattribute on sql provider annotation(such as@SelectProvider, etc).We has been supported the mechanism that use a shared sql provider class on all mapper methods, however developer need to specify explicitly the type on all mapper methods as follow:
mapper methods (on current version):
There is case that I feel it's redundant. As this changes, developer can be omit the type attribute on all mapper methods as follow:
mapper methods:
global configuration:
Note
The mybatis-thymeleaf and mybaits-freemarker provids the sql provider class(TemplateFilePathProvider) that can be use on all mapper methods. I want to use this mechanism when use these class.