Create dedicated setup type for SetupAllProperties#1234
Merged
stakx merged 6 commits intodevlooped:mainfrom Feb 15, 2022
Merged
Create dedicated setup type for SetupAllProperties#1234stakx merged 6 commits intodevlooped:mainfrom
SetupAllProperties#1234stakx merged 6 commits intodevlooped:mainfrom
Conversation
stakx
force-pushed
the
stubbedpropertiessetup
branch
3 times, most recently
from
c3f00b4 to
24d318d
Compare
stakx
force-pushed
the
stubbedpropertiessetup
branch
from
24d318d to
ae1a892
Compare
stakx
force-pushed
the
stubbedpropertiessetup
branch
5 times, most recently
from
ab1dc7c to
ac9de6e
Compare
stakx
force-pushed
the
stubbedpropertiessetup
branch
from
ac9de6e to
6b44eb7
Compare
stakx
force-pushed
the
stubbedpropertiessetup
branch
from
6b44eb7 to
e30183b
Compare
|
Hello @stakx, since we got version 4.18.1, our mocks' subclasses that call SetupAllProperties are crashing. public class MyInterfaceMock : Mock<IMyInterface>
{
public MyInterfaceMock ()
{
SetupAllProperties(); // Crashes here
}
}This isn't allowed anymore? |
Contributor
Author
|
@mo-russo, this is a regression. Could you please report the above again in a new issue, so that we can properly track it? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1204, where a dedicated setup type was created for single stubbed properties' accessors (i.e.
SetupProperty). Thanks to #1203, the same can also be done forSetupAllProperties.A few additional notes:
This gets rid of the
RemoveAllPropertyAccessorSetupsmethod inSetupCollection, restoring it to an add-only collection, which in turn means its use oflock-ing could be optimized in a similar fashion as was done forInvocationCollection.Gets rid of the
AutoSetupPropertiesDefaultValueProviderhack and simplifies the interception pipeline.Moq should become a little more efficient in principle, since there will be fewer setups created overall.
Fixes #1066, likely fixes #1231.