Sanitize sourceURL so it cannot affect evaled code#4518
Merged
jdalton merged 1 commit intolodash:4.17.15-postfrom Jun 4, 2020
Merged
Sanitize sourceURL so it cannot affect evaled code#4518jdalton merged 1 commit intolodash:4.17.15-postfrom
jdalton merged 1 commit intolodash:4.17.15-postfrom
Conversation
alexbrasetvik
force-pushed
the
stop-sourceurl-code-injection
branch
from
d2770b2 to
95d571f
Compare
Contributor
Author
|
@jdalton @falsyvalues It seems that the zipObjectDeep prototype pollution warrants an imminent release. Can I ask that you please consider including this change as well in a 4.17.16? :) |
Member
|
Thanks @alexbrasetvik! |
|
@jdalton could you please update us about how distant are we from having a lodash patch release with that fix on it? |
This was referenced Mar 9, 2021
jdalton
added
issue bankruptcy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wherever it comes from,
sourceURLshould not be allowed to contain code that gets eval()-ed./\s/should cover all the bases as far as I know, including the various unicode-y ways of encoding newlines.