Fix infinite recursion when merge sourcemaps#14274
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Feb 15, 2022
Merged
Fix infinite recursion when merge sourcemaps#14274nicolo-ribaudo merged 3 commits intobabel:mainfrom
nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51297/ |
JLHwung
added
area: sourcemaps
i: regression
PR: Bug Fix 🐛
JLHwung
approved these changes
Feb 15, 2022
nicolo-ribaudo
approved these changes
Feb 15, 2022
jridgewell
added a commit
to ampproject/remapping
that referenced
this pull request
Feb 16, 2022
It's important to know both the importer and the depth of the sourcemap tree when loading, to solve cases like babel/babel#14274. Here, a parent sourcemap contains a source location that, when resolved, has the same location as the parent. This easily happens when the file represents an in-place transformation of the original sourcemap (eg, `babel script.js --out-file script.js --source-maps`). Because they exist in the same location, it's extremely easy to create a loader which continues to return the transformed sourcemap when we intend to only return a `null` (no sourcemap) for the original source file.
github-actions
bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the input map contains a source file that resolves to the same location as input map, then we'd hit an infinite recursion when attempting to build the source map tree.