Allows passing size or custom alphabet via cli as args#334
Merged
Conversation
ai
reviewed
Jan 15, 2022
Owner
|
We need to improve test coverage. You can check test coverage locally by running |
Owner
|
We also need to fix Node.js 12 support for binary (we can’t use |
Contributor
Author
|
Done I've faced error Now it still works with Node 12 and test coverage is 100% |
Owner
|
And released in 3.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #275
I've implemented minimal args parsing logic to fit our needs and be as little as possible