TypeScript type definitions#66
Merged
TooTallNate merged 2 commits intoTooTallNate:masterfrom May 21, 2019
sadasant:patch-1
Merged
TypeScript type definitions#66TooTallNate merged 2 commits intoTooTallNate:masterfrom sadasant:patch-1
TooTallNate merged 2 commits intoTooTallNate:masterfrom
sadasant:patch-1
Conversation
Based on: #27 (comment) (thank you @yonilerner)
Owner
|
Thank you! |
Collaborator
Author
|
@TooTallNate yayy \o/ Don't we need to upgrade the version now? |
sadasant
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
May 21, 2019
Once https-proxy-agent type definitions are added, these changes will be necessary to make this sample work. The PR that introduces the TypeScript definitions to https-proxy-agent is: TooTallNate/proxy-agents#66 This commit is related to #3064
This was referenced Mar 9, 2021
This was referenced Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just to bring attention to the missing type definitions. Not everyone uses TypeScript, but for those who do, having this file in this repo would be incredibly helpful.
index.d.tsis based on: #27 (comment) (thank you @yonilerner)Please let us know if this is ok! Any form of feedback is appreciated.