actually do not camel case fx prefs#9944
Merged
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom Oct 20, 2021
Merged
Conversation
follow-up to eb2d017
titusfortner
approved these changes
Oct 20, 2021
Member
titusfortner
left a comment
There was a problem hiding this comment.
This is what happens when I don't write a test. Thanks for your submission.
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
firefox preferences must not be camelized. this was intended in eb2d017 but failed simply due to a type mismatch.
Motivation and Context
i wanted to set
intl.accepted_languagesbut in a firefox instance it ended up asintl.acceptedLanguagesand thus having no effect.Types of changes
Checklist
all tests in the scope of my changes are passing. many others don't. i consider them being wip.
before this pr: