cooklang syntax highlighting - initial add#3337
Merged
Merged
Conversation
RunDevelopment
requested changes
Feb 14, 2022
Member
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you for the PR @ahue!
I have a few comments for you.
Also, regarding quoting properties: We generally only quote token names (e.g. comment, timer-group) and leave everything else unquoted (e.g. pattern, inside). This makes grammars more readable because it's easier to see what is and isn't a token name.
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
RunDevelopment
requested changes
Feb 16, 2022
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Contributor
Author
|
@RunDevelopment - appreciate the feedback - it's really helpful! |
RunDevelopment
requested changes
Feb 18, 2022
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
RunDevelopment
approved these changes
Feb 19, 2022
Member
|
Thank you for contributing @ahue! |
Contributor
Author
|
Thanks for running this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds syntax highlighting for cooklang.