Simplify JacksonXmlRootElement Customizations#32806
Merged
alzimmermsft merged 1 commit intoAzure:mainfrom Jan 6, 2023
Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-storage-blob |
ibrahimrabab
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the pattern of removing the
JacksonXmlRootElementand adding it back with the newlocalNameby usingcustomizeAstto replace just the value oflocalName. This should resolve an issue being seen in CI where adding and removingJacksonXmlRootElementmay result in a diff being seen whereJacksonXmlRootElementis no longer being imported by the class.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines