Skip to content

Simplify JacksonXmlRootElement Customizations#32806

Merged
alzimmermsft merged 1 commit intoAzure:mainfrom
alzimmermsft:AzStorage_SimplifyCustomizations
Jan 6, 2023
Merged

Simplify JacksonXmlRootElement Customizations#32806
alzimmermsft merged 1 commit intoAzure:mainfrom
alzimmermsft:AzStorage_SimplifyCustomizations

Conversation

@alzimmermsft
Copy link
Member

Description

Replaces the pattern of removing the JacksonXmlRootElement and adding it back with the new localName by using customizeAst to replace just the value of localName. This should resolve an issue being seen in CI where adding and removing JacksonXmlRootElement may result in a diff being seen where JacksonXmlRootElement is no longer being imported by the class.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Jan 6, 2023
@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jan 6, 2023
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 6, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob
azure-storage-file-share
azure-storage-queue

@alzimmermsft alzimmermsft merged commit 6b1822c into Azure:main Jan 6, 2023
@alzimmermsft alzimmermsft deleted the AzStorage_SimplifyCustomizations branch January 6, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants