Skip to content

Fixing cspell spelling errors in spring packages#32780

Merged
Netyyyy merged 5 commits intoAzure:mainfrom
Netyyyy:myao/fix_cspell
Jan 6, 2023
Merged

Fixing cspell spelling errors in spring packages#32780
Netyyyy merged 5 commits intoAzure:mainfrom
Netyyyy:myao/fix_cspell

Conversation

@Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Jan 5, 2023

As title.
Fixes: #31612, #31636, #31638, #31639, #31641

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure

@Netyyyy Netyyyy marked this pull request as ready for review January 6, 2023 00:53
@Netyyyy Netyyyy merged commit 7fbd2d8 into Azure:main Jan 6, 2023
@Bean
@ConditionalOnMissingBean
// TODO (xiada): spring data cosmos also defines a CosmosAsyncClient
// TODO: spring data cosmos also defines a CosmosAsyncClient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be changed, it is just false alarm from the spell checking tool, the correct way is fixing it there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes in #32844

@Netyyyy Netyyyy deleted the myao/fix_cspell branch January 20, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdk/boms/spring-cloud-azure-dependencies - cspell found spelling errors in package

4 participants