[Perf] Change default warmup and duration to 15 seconds#32528
Merged
mikeharder merged 1 commit intoAzure:mainfrom Dec 9, 2022
Merged
[Perf] Change default warmup and duration to 15 seconds#32528mikeharder merged 1 commit intoAzure:mainfrom
mikeharder merged 1 commit intoAzure:mainfrom
Conversation
- Other languages default to 5 second warmup and 10 second duration - Java needs more time to warmup the JVM and reach max throughput
alzimmermsft
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently set the default warmup and duration to 15 seconds in the perf automation:
https://github.com/Azure/azure-sdk-tools/blob/2b9d1abf6e7ba7f301dae9d18b5fc37af3414597/tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/tests.yml#L68
I think it makes more sense to move this down to the Java perf framework itself. This will also allow us to remove the
AdditionalArgumentsfeature from the perf automation, since it should no longer be needed once Azure/azure-sdk-tools#3530 is complete