[TA] Add domainFilter feature to PII endpoint#14714
Merged
mssfang merged 7 commits intoAzure:masterfrom Sep 4, 2020
Merged
Conversation
ghost
added
the
mssfang
added
the
Client
iscai-msft
approved these changes
Sep 2, 2020
| "Recognized Personally Identifiable Information entity: %s, entity category: %s," | ||
| + " entity subcategory: %s, confidence score: %f.%n", | ||
| entity.getText(), entity.getCategory(), entity.getSubcategory(), entity.getConfidenceScore())); | ||
| // END: com.azure.ai.textanalytics.TextAnalyticsClient.recognizePiiEntities#String-String-RecognizePiiEntityOptions |
Contributor
There was a problem hiding this comment.
Can you add a test for domain filter where a returned entity gets filtered out? Here is a python test for taht
Contributor
Author
There was a problem hiding this comment.
There are a few tests for domain filter already in the PR. You are looking at the codesnippet section. https://github.com/Azure/azure-sdk-for-java/pull/14714/files#diff-9df5b3d7d96dd8e2313b619beb609285R509
maririos
reviewed
Sep 2, 2020
...zure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClient.java
Show resolved
Hide resolved
maririos
reviewed
Sep 2, 2020
...zure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClient.java
Show resolved
Hide resolved
maririos
reviewed
Sep 2, 2020
...re-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/PiiEntityDomainType.java
Outdated
Show resolved
Hide resolved
maririos
reviewed
Sep 2, 2020
...textanalytics/src/main/java/com/azure/ai/textanalytics/models/RecognizePiiEntityOptions.java
Outdated
Show resolved
Hide resolved
samvaity
reviewed
Sep 2, 2020
...ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizePiiEntityAsyncClient.java
Outdated
Show resolved
Hide resolved
...re-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/PiiEntityDomainType.java
Show resolved
Hide resolved
Contributor
Author
|
/azp run java - textanalytics - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - textanalytics - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - textanalytics - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
samvaity
reviewed
Sep 3, 2020
...re-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/PiiEntityDomainType.java
Outdated
Show resolved
Hide resolved
...ics/src/test/resources/session-records/recognizePiiEntitiesForBatchInputForDomainFilter.json
Show resolved
Hide resolved
samvaity
approved these changes
Sep 4, 2020
| private Mono<Response<RecognizePiiEntitiesResultCollection>> getRecognizePiiEntitiesResponse( | ||
| Iterable<TextDocumentInput> documents, TextAnalyticsRequestOptions options, Context context) { | ||
| Iterable<TextDocumentInput> documents, RecognizePiiEntityOptions options, Context context) { | ||
| String modelVersion = null; |
Member
There was a problem hiding this comment.
Just confirming, it is fine to send the modelVersion and domainFilter as null to the service?
maririos
approved these changes
Sep 4, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 21, 2021
Adding iperf APIs (Azure#14714) * Adding iperf APIs * Addressing review comments * Addressing PR comments * Removing APIs unimplemented in Sterling * Fixing resource schemas * Fixing linting errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #14713