chore(promises): removed support for custom promise libraries #12878
Conversation
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
In test/connection.test.js we use the package q and bluebird. I wonder if we can remove those tests too? @vkarpov15
lib/helpers/promiseOrCallback.js
Outdated
| } | ||
|
|
||
| Promise = Promise || PromiseProvider.get(); | ||
| Promise = Promise || global.Promise || require('bluebird'); |
There was a problem hiding this comment.
What happens if bluebird is not installed? Crash gracefully?
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
mostly looks good to me, though there are some test things that should maybe be changed
also i think this change should target the next major version instead of master (/ 6.x)
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
LGTM, i think that bluebird and q can now be removed from the package.json
|
Maybe add it as an inclusion to the migration DOC 😅 although it is in the changelog. I went from v5 -> v7 and found out the hard way lol I found this because of that commit message on the main page |
|
just as a note, if you still want to use custom promises, you should be able to do: global.Promise = YourCustomPromise; |
5 participants
closes #12872