Fix --gather-test-outputs-in fails when tests change directory #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bats-core#1132 Convert relative paths to absolute when processing --gather-test-outputs-in to ensure paths remain valid when tests change directory with 'cd'. Also add defensive check for BATS_OUT existence before copying.
jnasbyupgrade
force-pushed
the
fix-gather-test-outputs-in-cd-issue
branch
from
a60f921 to
509e2d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1132
Problem
When using
--gather-test-outputs-inwith a relative path, if a test changes directory usingcd, thecpcommand fails with "No such file or directory" because relative paths become invalid when the current working directory changes.Solution
Convert relative paths to absolute paths when processing the
--gather-test-outputs-inoption in thebatsscript, ensuring the path remains valid regardless of directory changes within tests.Also add a defensive check to ensure
BATS_OUTexists before copying, preventing errors if a test produces no output.Changes
libexec/bats-core/bats: Convert relative output directory paths to absolute pathslibexec/bats-core/bats-exec-test: CheckBATS_OUTexists before copyingtest/fixtures/bats/cd_in_test.bats: Add test fixture that changes directorytest/bats.bats: Add test case to verify fix works with relative pathsTesting