📖 [Story documentation] Fix page attachment docs location#37669
Merged
mszylkowski merged 15 commits intoampproject:mainfrom Feb 14, 2022
Merged
📖 [Story documentation] Fix page attachment docs location#37669mszylkowski merged 15 commits intoampproject:mainfrom
mszylkowski merged 15 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
newmuis
approved these changes
Feb 14, 2022
Contributor
|
qq: I'm able to find the page attachment doc from the direct link, yet not able to navigate to the page from the side panel (it doesn't exist in the side panel). Wondering if it's related to this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently the amp-story-page-attachment documentation disappeared: https://amp.dev/documentation/components/amp-story-page-attachment/?format=stories
This is due to a new extension existing that doesn't have the
.mdfile in the directory, soamp-story-page-attachmentdoesn't direct towards the document that it should. This can be fixed by moving the page attachment documentation to the new extension.