Skip to content

✨ [AMP Story Paywall] Handles grant status and show/hide paywall dialog in amp-story-subscriptions#37892

Merged
ychsieh merged 127 commits intoampproject:mainfrom
ychsieh:amp-story-subscription
Mar 31, 2022
Merged

✨ [AMP Story Paywall] Handles grant status and show/hide paywall dialog in amp-story-subscriptions#37892
ychsieh merged 127 commits intoampproject:mainfrom
ychsieh:amp-story-subscription

Conversation

@ychsieh
Copy link
Contributor

@ychsieh ychsieh commented Mar 17, 2022

  • Add the callback that handles grant status to be execute when 1) initial grant response during subscription service setup 2) all following grant response after users do actions like subscribe or log in.
  • Show/hide dialog UI when the dialog UI state is switched.

ychsieh and others added 30 commits January 20, 2022 18:19
… validator in npm contains the new validator rule files in this PR.
…tion in AmpStoryPage to check if paywall protected. Also some fixes.
…ion to prevent the double loading issue of the new extension.
@ychsieh ychsieh marked this pull request as ready for review March 22, 2022 23:26
@ychsieh ychsieh requested a review from calebcordry March 24, 2022 00:52
@calebcordry calebcordry requested a review from gmajoulet March 25, 2022 03:33
@calebcordry
Copy link
Member

We want to make sure to clean up state between tests, otherwise LGTM

@ychsieh ychsieh requested a review from calebcordry March 25, 2022 04:32
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants