✨ [AMP Story Paywall] Handles grant status and show/hide paywall dialog in amp-story-subscriptions#37892
Merged
ychsieh merged 127 commits intoampproject:mainfrom Mar 31, 2022
Merged
Conversation
Contributor
ychsieh
commented
Mar 17, 2022
- Add the callback that handles grant status to be execute when 1) initial grant response during subscription service setup 2) all following grant response after users do actions like subscribe or log in.
- Show/hide dialog UI when the dialog UI state is switched.
…tory. Boilerplate code only.
Co-authored-by: Caleb Cordry <[email protected]>
… validator in npm contains the new validator rule files in this PR.
…attributes to corresponding story pages.
…tion in AmpStoryPage to check if paywall protected. Also some fixes.
…nctions and do it in the new extension
…ion to prevent the double loading issue of the new extension.
…herwise it won't find anything.
…appens before dispatching the event.
…mphtml into amp-story-subscriptions
calebcordry
reviewed
Mar 23, 2022
extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-subscriptions/0.1/test/test-amp-story-subscriptions.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-subscriptions/0.1/test/test-amp-story-subscriptions.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-subscriptions/0.1/test/test-amp-story-subscriptions.js
Outdated
Show resolved
Hide resolved
calebcordry
reviewed
Mar 25, 2022
extensions/amp-story-subscriptions/0.1/test/test-amp-story-subscriptions.js
Outdated
Show resolved
Hide resolved
extensions/amp-story-subscriptions/0.1/test/test-amp-story-subscriptions.js
Outdated
Show resolved
Hide resolved
Member
|
We want to make sure to clean up state between tests, otherwise LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.